Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Update sparse data generation #23323

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

TomAugspurger
Copy link
Contributor

There's a spurious failure on master when the first
is randomly chosen to be 0, since type(arr.fill_value) doesn't
match arr.dtype.type

#23124 will fix the underlying issue, but this works around it so we don't have tests failing randomly.

Closes #23168

There's a spurious failure on master when the first
is randomly chosen to be 0, since type(arr.fill_value) doesn't
match arr.dtype.type
@pep8speaks
Copy link

Hello @TomAugspurger! Thanks for submitting the PR.

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Oct 24, 2018
@TomAugspurger TomAugspurger added Sparse Sparse Data Type Unreliable Test Unit tests that occasionally fail labels Oct 24, 2018
@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #23323 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23323   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         169      169           
  Lines       50911    50911           
=======================================
  Hits        46954    46954           
  Misses       3957     3957
Flag Coverage Δ
#multiple 90.65% <ø> (ø) ⬆️
#single 42.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c26375...f534f0e. Read the comment docs.

@TomAugspurger TomAugspurger merged commit c584ae7 into pandas-dev:master Oct 25, 2018
@TomAugspurger TomAugspurger deleted the sparse-hotfix branch October 25, 2018 11:06
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
There's a spurious failure on master when the first
is randomly chosen to be 0, since type(arr.fill_value) doesn't
match arr.dtype.type
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
There's a spurious failure on master when the first
is randomly chosen to be 0, since type(arr.fill_value) doesn't
match arr.dtype.type
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
There's a spurious failure on master when the first
is randomly chosen to be 0, since type(arr.fill_value) doesn't
match arr.dtype.type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sparse Sparse Data Type Unreliable Test Unit tests that occasionally fail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky SparseArray tests
2 participants